Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing + or any action to exit a Homebrew, fails and reopens instead #1

Open
rlaphoenix opened this issue Nov 11, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@rlaphoenix
Copy link
Owner

rlaphoenix commented Nov 11, 2022

Describe the bug
Any action that is meant to exit the Homebrew (and go back to e.g., the Homebrew Menu or Home Menu) is failing and instead just closes and reopens the Homebrew.

To Reproduce
Steps to reproduce the behavior:

  1. Make an NSP for Homebrew Menu or use the premade one.
  2. Install it with Goldleaf.
  3. Open it and press + once the menu has fully loaded.

You will see it go black and reopen, kind of like a refresh in this case.

Expected behavior
It was meant to close the homebrew and the forwarder entirely.

Screenshots
N/A.

Additional context
Some users have reported crashes when done instead of it closing and reopening.

@rlaphoenix rlaphoenix added the bug Something isn't working label Nov 11, 2022
@rlaphoenix
Copy link
Owner Author

rlaphoenix commented Nov 11, 2022

This issue is likely needing to be handled by the exefs ROM, of which we do not have source code for at the moment. So currently this issue is out of scope of this project.

@rlaphoenix
Copy link
Owner Author

The Forwarder ROM is now Open-Source: https://github.com/Skywalker25/Forwarder-Mod

@rlaphoenix rlaphoenix added the help wanted Extra attention is needed label Nov 13, 2022
@Skywalker25
Copy link
Contributor

Skywalker25 commented Nov 14, 2022

I did some research and I found that someone else had made a patch to allow a nro forwarder to exit via B/+button or by closing the nro via inside the forwarder. I copied the patch into the forwarder mod and it seems to have work, I've only tried awoo-installer nro, and a snes retroarch forwarder. awoo installer was able to exit to home menu via B button and closing in-app. and the retroarch forwarder was able to exit to home menu via closing the game from retroarch menu. the exefs contains the latest hbl 2.4.3 forwarder mod and the exit patch exefs.zip

@rlaphoenix
Copy link
Owner Author

I did some research and I found that someone else had made a patch to allow a nro forwarder to exit via B/+button or by closing the nro via inside the forwarder. I copied the patch into the forwarder mod and it seems to have work, I've only tried awoo-installer nro, and a snes retroarch forwarder. awoo installer was able to exit to home menu via B button and closing in-app. and the retroarch forwarder was able to exit to home menu via closing the game from retroarch menu. the exefs contains the latest hbl 2.4.3 forwarder mod and the exit patch exefs.zip

Could you add the modifications to your source repository of the Forwarder-Mod?

@rlaphoenix
Copy link
Owner Author

rlaphoenix commented Dec 11, 2022

It seems to work, but DBI is very weird with it. It seems to be laggy when first opening it and selecting the Exit option from the menu or pressing the B button causes it to freeze for a good 15-30s and then it closes (no errors). Strange. Do you get this behaviour as well?

Edit: If you wait that 15-30s before exiting, it exits immediately. This is likely just DBI having a fit.
If you can put the patches on your GitHub repo then I will push this and make a new version release.

@rlaphoenix
Copy link
Owner Author

I've committed the exefs rom you provided to master, but source code for the changes would be great.

@HookedBehemoth
Copy link

HookedBehemoth commented Jun 6, 2023

I assume he meant this patch: switchbrew/nx-hbloader@master...HookedBehemoth:nx-hbloader:master

I forgot how this was supposed to work but there also was a custom hbmenu switchbrew/nx-hbmenu@master...HookedBehemoth:nx-hbmenu:sane_exit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants