Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcuts - Add opt-in option #220

Open
superlinkx opened this issue Apr 22, 2024 · 2 comments
Open

Keyboard Shortcuts - Add opt-in option #220

superlinkx opened this issue Apr 22, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@superlinkx
Copy link

Describe the bug
Having shortcuts that use ctrl+shift+t as a chord cause the commonly bound ctrl+shift+t shortcut to be overwritten as the start of a chord, breaking reopening a closed tab by default.

To Reproduce
Steps to reproduce the behavior:

  1. Use default keybinds
  2. Close an open tab
  3. Press ctrl+shift+t
  4. Note that at the bottom of the editor, VS Code is waiting for the rest of a chord
  5. Closed tab won't reopen

Expected behavior
Existing keybind should be respected, and by default that means it should reopen a closed editor tab

Desktop (please complete the following information):

  • OS: Windows 11 and WSL 2 Ubuntu 22.04
  • Browser: N/A
  • Version: VS Code v1.88.1 with Twinny v3.11.19

Additional context
It may be wise to not create keyboard shortcuts by default and let users opt-in

@rjmacarthy
Copy link
Owner

Hey thanks for the report, sorry about that! I just updated the keyboard shortcuts to not override any defaults. Opt-in would require more work and I'm too lazy at the moment to work on it :).

Many thanks,

@superlinkx
Copy link
Author

Appreciate all the work you do, I've been loving this extension otherwise!

@rjmacarthy rjmacarthy changed the title Keyboard Shortcuts Break Defaults Keyboard Shortcuts - Add opt-in option Apr 23, 2024
@rjmacarthy rjmacarthy added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants