Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline suggestion does not work when there is a .hg folder #212

Open
sebastianelsner opened this issue Apr 16, 2024 · 1 comment
Open

Inline suggestion does not work when there is a .hg folder #212

sebastianelsner opened this issue Apr 16, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sebastianelsner
Copy link
Contributor

Describe the bug

It seems inline suggestion does not work in projects using mercurial, which has a .hg folder, as the files twinny uses have the extension of the SCM folder, which is removed in:

this._currentFile = filePath.replace('.git', '')

The Error is:

2024-04-16 10:27:29.269 [error] [rjmacarthy.twinny] provider FAILED
2024-04-16 10:27:29.269 [error] CodeExpectedError: cannot open file:///raid/standards/base-setups/risebase/production/scripts/auto_inactive.py.hg. Detail: Unable to read file '/raid/standards/base-setups/risebase/production/scripts/auto_inactive.py.hg' (Error: Unable to resolve nonexistent file '/raid/standards/base-setups/risebase/production/scripts/auto_inactive.py.hg')
at r.$tryOpenDocument (vscode-file://vscode-app/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:2163:62448)

To Reproduce
Steps to reproduce the behavior:

  1. Have a mercurial repo (install mercurial, hg init)
  2. create file
  3. trigger inline completion
  4. See error in extension host output

Expected behavior
The inline completions should work

@rjmacarthy
Copy link
Owner

Thanks for the report. Will investigate for future release.

@rjmacarthy rjmacarthy added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 17, 2024
sebastianelsner added a commit to sebastianelsner/twinny that referenced this issue May 6, 2024
This is fixing issue rjmacarthy#212
sebastianelsner added a commit to sebastianelsner/twinny that referenced this issue May 13, 2024
sebastianelsner added a commit to sebastianelsner/twinny that referenced this issue May 13, 2024
rjmacarthy added a commit that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants