Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's confusing that remove dup lines has two meanings in different submenu. #5154

Open
LennaHammer opened this issue Mar 12, 2024 · 1 comment

Comments

@LennaHammer
Copy link

when using lines > remove dup lines, it works like the uniq command which keeps the first dup line,

but when using selections > sort lines > remove dup lines, the lines that appear twice will all be removed.

it's very confusing that the same command has two different meanings in two different submenus. I've used these commands incorrectly, I think it can be avoided by providing a better name.

@LennaHammer LennaHammer changed the title it's confusing that remove dup lines has two meanings in different place. it's confusing that remove dup lines has two meanings in different submenu. Mar 12, 2024
@RaiKoHoff
Copy link
Collaborator

@hpwamr : No it is no bug or regression, this is an option within the "Sort lines" working as designed.
@LennaHammer is correct, that the wording is not chosen well and may be misleading.

  1. Remove unique lines. => OK
  2. Remove empty lines. => OK
  3. Remove white-space lines. => called in the Edit -> Lines -> menu: Remove Blank Lines - better: use same wording
  4. Remove duplicate lines. => the meaning is as described by @LennaHammer : remove all duplicates (incl. first one) maybe we can find a better wording here.
  5. Merge duplicate lines. => Merge duplicate lines (into the first one) - this is the same functionality as menu Edit -> Lines -> Remove Duplicate Lines - which removes all dupes except the first/original line.

So, functionality is correct - we should find better wording here - any suggestions ?

xxx.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants