Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube plugin not correctly parsing full urls #267

Open
vinnyvimto opened this issue Aug 9, 2018 · 1 comment
Open

YouTube plugin not correctly parsing full urls #267

vinnyvimto opened this issue Aug 9, 2018 · 1 comment

Comments

@vinnyvimto
Copy link

Using the YouTube plugin the url https://www.youtube.com/watch?v=example&t=6s is not parsed correctly.

The only part passed is youtube.com/watch?v=example leaving the embedded video wrapped in https:// and &t=6s

@ritz078
Copy link
Owner

ritz078 commented Oct 13, 2018

This package currently uses https://github.com/regexhq/youtube-regex for parsing the urls. Would you be willing to make a change and submit a PR ?

The line that needs to be changed is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants