Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer: add property sorted to plan nodes #601

Open
skyzh opened this issue Apr 3, 2022 · 3 comments
Open

optimizer: add property sorted to plan nodes #601

skyzh opened this issue Apr 3, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@skyzh
Copy link
Member

skyzh commented Apr 3, 2022

We can have a struct like PlanBase, which is included in all optimizer plan nodes. Then, we can have sorted inside, along with the sort keys (e.g. struct PlanBase { sorted: Vec<usize> }), and add code to infer the property across plan nodes.

@skyzh skyzh mentioned this issue Apr 3, 2022
18 tasks
@skyzh skyzh changed the title optimizer: add property is_sorted to plan nodes optimizer: add property sorted to plan nodes Apr 3, 2022
@skyzh skyzh added the enhancement New feature or request label Apr 28, 2022
@shmiwy
Copy link
Contributor

shmiwy commented May 6, 2022

Let me have a try! : )

@skyzh
Copy link
Member Author

skyzh commented May 7, 2022

I think we can start with #645 first, and make range filter scan more powerful and useful later with sorted property induction. 🤪 We can postpone this issue a little bit.

@wangrunji0408
Copy link
Member

In the new planner, this can be implemented as an analysis. The associated data could be Vec<(key: Id, asc_or_desc: bool)>. After this is done, we could have sort-merge-join and sort-group-agg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants