Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 'album' Field in Recommendations.TrackSimple from recommendations.get API #176

Open
tikbox opened this issue Nov 21, 2023 · 2 comments · May be fixed by #180
Open

Missing 'album' Field in Recommendations.TrackSimple from recommendations.get API #176

tikbox opened this issue Nov 21, 2023 · 2 comments · May be fixed by #180

Comments

@tikbox
Copy link

tikbox commented Nov 21, 2023

Issue Summary:
The recommendations.get API endpoint is returning incomplete data for the Recommendations.TrackSimple object. Specifically, the 'album' field is missing from the response, despite it being documented in the official API documentation. This issue is impacting the ability to retrieve complete information about recommended tracks.

Expected Behavior:
The Recommendations.TrackSimple object should include the 'album' field in the response, as specified in the official API documentation.

Thank you for your attention to this matter.
@rinukkusu
Copy link
Owner

You are right - looking at the documentation there is indeed an album field in the example response. On the other hand the tracks array itself is made up of simplified versions of the Track object, as stated in that same documentation, which should not contain an album.

An array of track object (simplified) ordered according to the parameters supplied.

I think this is something we could tackle with the model classes rewrite in issue #172 - so we could have like a mixin or something for this specific case.

For now we could switch the tracks array to an array of the "full" Track class. Some fields might be empty of course. What do you think @hayribakici ?

@hayribakici
Copy link
Collaborator

Makes sense, @rinukkusu.

@rinukkusu rinukkusu linked a pull request Nov 29, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt recommendations to include a full track object with a full album rinukkusu/spotify-dart
3 participants
@rinukkusu @hayribakici @tikbox