Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention usage of Message Authentication Codes #18

Open
NotAFile opened this issue May 16, 2018 · 2 comments
Open

Mention usage of Message Authentication Codes #18

NotAFile opened this issue May 16, 2018 · 2 comments

Comments

@NotAFile
Copy link

NotAFile commented May 16, 2018

I believe that it is somewhat irresponsible to not mention Message Authentication. Otherwise, users will copy the insecure code in the README without realizing e.g. CBC without a MAC is trivially broken.

@ricmoo
Copy link
Owner

ricmoo commented May 16, 2018

You are welcome to update the documentation and submit a pull request, but please keep in mind this library is for a cryptographic primitive, so it’s scope is intentionally limited.

There are many ways to use AES in general, and not all uses of CBC require (or can even support) a MAC, but an outline (and links to Wikipedia) of how and when to use a MAC would be wonderful.

Thanks! :)

@cristianocca
Copy link

Might want to also mention that AES CTR is malleable (ciphertext can be easily modified and remain unnoticed if no authentication is done as mentioned above) and also if encrypted data belongs to a small domain of possible values, those values can be guessed if the same counter initialization value is reused for every encryption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants