Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual flow discontinuity #65

Open
ralienpp opened this issue Nov 14, 2018 · 5 comments
Open

Visual flow discontinuity #65

ralienpp opened this issue Nov 14, 2018 · 5 comments

Comments

@ralienpp
Copy link
Contributor

I am observing an effect that I am not sure I can make sense of:

image

In the targeted ads waypoint, the three bottom inputs on the left get out in a different order on the right. I noticed that in other sections, floweaver is overlaying the curves, and I was expecting the same thing to happen here.

Is this by design?

Personal note: I discovered the library yesterday and I am very impressed with how visually attractive the results are. I am still wrapping my head in the ideology of the API, but I was able to obtain some decent results with little effort - impressive!

@ralienpp
Copy link
Contributor Author

ralienpp commented Dec 7, 2018

I'd like to get back to this matter, with a more complete example:

image

If you look at the bottom right corner of the diagram, you see UV radiation and wind speed going into Cornix. The curves are swapped as they exit the second waypoint, though it would be more visually attractive if they simply went on. What rule is used to determine the order, in which the items are placed on the diagram? Can it be controlled?

@ricklupton
Copy link
Owner

Hi, glad you're finding it useful and sorry for the slow reply!

Thanks for the clear examples of this problem. There's definitely scope for improving it, but at the moment the algorithm is pretty basic. When there are two links between the same source and target (in your case, between "other" and "Cornix") the links are sorted lexically by their type. So as a workaround, you can name the types corresponding to the yellow and brown colours so that "wind speed" sorts before "UV radiation", e.g. by adding numbers to the beginning. You need to do this only in the flow_partition.

Hope that makes sense!

This is an area I'd like to improve, and contributions are welcome, just get in touch.

@obbe79
Copy link

obbe79 commented May 21, 2020

Hi, glad you're finding it useful and sorry for the slow reply!

Thanks for the clear examples of this problem. There's definitely scope for improving it, but at the moment the algorithm is pretty basic. When there are two links between the same source and target (in your case, between "other" and "Cornix") the links are sorted lexically by their type. So as a workaround, you can name the types corresponding to the yellow and brown colours so that "wind speed" sorts before "UV radiation", e.g. by adding numbers to the beginning. You need to do this only in the flow_partition.

Hope that makes sense!

This is an area I'd like to improve, and contributions are welcome, just get in touch.

Hi,
could you explain further what do you mean by "naming types"? Wouldn't the changed names appear on the diagram, too?

In fact having the final flows group together by color would be a great improvement.
Thanks.

@jmca3
Copy link

jmca3 commented May 21, 2020

Hello,

I would like to point out another example of this. I would be great if the order "remained the same" regardless of the name of the types, i. e. split and non-split flows ordered in the same way.

sankey_full

@annamarchenkova
Copy link

Hi, there!

Any news on this issue?
I'm having the same problem with a bit more difficult example that's not easy to hack with just renaming the types, because in the last flow (doing/done) there are many target flows, and many of them are split by the type, so even if I sort types within each individual flow it would not help the overall visual appearance much.

Any suggestions? Maybe there were already any attempts to resolve this issue and I can help? It would be such an awesome feature to implement!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants