Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save temp file with file extension #273

Open
toksdotdev opened this issue May 29, 2021 · 2 comments
Open

Save temp file with file extension #273

toksdotdev opened this issue May 29, 2021 · 2 comments

Comments

@toksdotdev
Copy link

I'm proposing that we save the temp file with the file extension, considering that in some cases, one might have a logic that depends on the file extension.

Currently, when a temp file is created, it strips out the file extension as shown here

Since we have the filename, we should be able to inject it into the getTempFilename(...).

I'll be very much open to creating a PR if you deem fit.

@RomanBurunkov
Copy link
Collaborator

Hi,

But the file object has a name property and in case you need an extension it is possible to get it from the original file name.

@picturedots
Copy link

I posted a workaround in stack overflow that

  1. gets the extension from the file object's "name"
    
  2. renames the temporary file to use the extension
    

But it will still be better for this to be the default behavior if useTempFiles: true and preserveExtension: true are used together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants