Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to download jars from Maven #1

Open
risdenk opened this issue Jun 13, 2019 · 1 comment
Open

Suggestion to download jars from Maven #1

risdenk opened this issue Jun 13, 2019 · 1 comment
Assignees

Comments

@risdenk
Copy link

risdenk commented Jun 13, 2019

Just providing some potentially unwanted feedback :)

I looked through the patches real quick and it looks like they are just dependency updates. You should be able to download jars from Maven with (curl, wget, etc) and put in the right place - move/remove old versions as well.

This would avoid having to recompile Solr with the dependency changes. If you already have to package Solr for other reasons then ok, but just sharing in case it helps.

@richardbadman richardbadman self-assigned this Jun 24, 2019
@richardbadman
Copy link
Owner

Thanks for your feedback, any feedback is welcomed and appreciated.

That's a good point, and saw in your original repository that is what you did. For the use-case of where I work, we compile the project and convert it to a debian package, which is why the current patch is more applicable here.

But I'll add your suggestions in due course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants