Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Simplify usage #5

Open
BoShurik opened this issue Jan 12, 2021 · 1 comment
Open

[RFC] Simplify usage #5

BoShurik opened this issue Jan 12, 2021 · 1 comment
Labels
enhancement New feature or request v2 Everything that should be added to the v2

Comments

@BoShurik
Copy link

$service = new OEmbed();

$result = $service->get(
    // Instead of new Uri('https://www.facebook.com/FacebookDeutschland/videos/2403439749688130/')
    'https://www.facebook.com/FacebookDeutschland/videos/2403439749688130/', 
    480,
    300,
    ['omitscript' => true]
);

echo (string)$result;

OEmbed has UriFactoryInterface instance so can create Uri by themself

@ricardofiorani
Copy link
Owner

@BoShurik Thank you for your suggestion.
Given that this breaks backward compatibility, it would be considered a major release, therefore, I'm adding the tag v2 to this issue to be considered in the future.

@ricardofiorani ricardofiorani added enhancement New feature or request v2 Everything that should be added to the v2 labels Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 Everything that should be added to the v2
Projects
None yet
Development

No branches or pull requests

2 participants