Skip to content
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.

Rename the executable_path option to node_path #11

Open
nesk opened this issue Jul 26, 2018 · 0 comments
Open

Rename the executable_path option to node_path #11

nesk opened this issue Jul 26, 2018 · 0 comments
Labels
breaking changes The API will break if this issue or pull request is approved
Milestone
v2.0.0

Comments

@nesk
Copy link
Member

nesk commented Jul 26, 2018 •
edited

The actual option name is confusing.

This:

https://github.com/nesk/rialto/blob/e51cd3106cdf046a11fd18cef9a48e7f5bac71d3/src/ProcessSupervisor.php#L41-L42

should become:

// Node's executable path 
'node_path' => 'node',

Note: all occurences of executable_path should be replaced in the documentation.
@nesk nesk added the breaking changes The API will break if this issue or pull request is approved label Jul 26, 2018
@nesk nesk added this to the v2.0.0 milestone Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking changes The API will break if this issue or pull request is approved
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@nesk