Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espeak_TextToPhonemesWithTerminator not upstream #30

Open
cryptomilk opened this issue Mar 11, 2024 · 5 comments
Open

espeak_TextToPhonemesWithTerminator not upstream #30

cryptomilk opened this issue Mar 11, 2024 · 5 comments

Comments

@cryptomilk
Copy link

cryptomilk commented Mar 11, 2024

Hi,

I'm trying to package piper-tts for openSUSE right now.

  • Is there a reason that espeak_TextToPhonemesWithTerminator() has not been submitted upstream to espeak-ng?
  • I've changed the CMakeLists.txt so I can build with system libraries, would you accept a patch for this?

https://build.opensuse.org/package/show/home:gladiac/piper-phonemize
https://build.opensuse.org/package/show/home:gladiac/piper-tts

@cryptomilk
Copy link
Author

The strange thing is that the prototype of TranslateClauseWithTerminator() made it upstream: espeak-ng/espeak-ng#1811

@synesthesiam
Copy link
Contributor

That's very odd that they merged the function prototype with no definition! I didn't submit it upstream for two reasons:

  1. I didn't add any tests, and wasn't sure it was even useful outside of Piper
  2. I plan on replacing espeak-ng with something else due to licensing concerns (I prefer MIT/public domain over GPL)

@cryptomilk
Copy link
Author

I would still try to submit it. I think they would accept it and it would be easier to build piper-tts in distributions. I would love to bring piper-tts to openSUSE and Fedora.

@cryptomilk
Copy link
Author

I've open a pull request for cmake improvements: #31

@danemadsen
Copy link

espeak-ng/espeak-ng#1878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants