libgit2/git2go fails to build due to pkg-config error

[raylu]

on my mac:

$ go version
go version go1.9.4 darwin/amd64

$ git show
commit ffbd489206c5e76b5c2e7ac251f088880678ea06 (HEAD -> master, tag: v0.1.2, origin/master, origin/HEAD)
[...]
Date:   Wed Feb 7 20:15:05 2018 +0000
[...]

$ make
[...]
go build github.com/rgburke/grv/cmd/grv/vendor/gopkg.in/libgit2/git2go.v25: invalid pkg-config package name: --static
make[1]: *** [install-static] Error 1
make: *** [build-libgit2] Error 2

$ go build --tags static -ldflags "-X 'main.version=v0.1.2-0-gffbd489' -X 'main.headOid=ffbd489' -X 'main.buildDateTime=2018-02-07 13:37:56 PST'" -o grv ./cmd/grv
go build github.com/rgburke/grv/cmd/grv/vendor/gopkg.in/libgit2/git2go.v25: invalid pkg-config package name: --static

[rgburke]

Thanks for reporting this issue. It should now be fixed on master. Could you please pull the latest code and confirm?

Go 1.9.4 has introduced flag checks for cgo build directives. git2go uses pkg-config: --static ... and go 1.9.4 doesn't recognise --static as a valid argument. So as I can't directly fix this a workaround has been implemented instead as described here

[raylu]

it builds! thanks!