Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PureText NORMAL vs STRICT MODE always uses STRICT mode #1458

Open
Madisonw opened this issue Jul 10, 2019 · 2 comments
Open

PureText NORMAL vs STRICT MODE always uses STRICT mode #1458

Madisonw opened this issue Jul 10, 2019 · 2 comments
Labels
type-bug

Comments

@Madisonw
Copy link

https://github.com/revel/revel/blob/a3d7a7c23ca885cc5036d3641ede49ce4a14ee2e/validators.go#L569:L572

The world's most opinionated Switch statement directs you to PureTextStrict regardless of if you are in PureText NORMAL or PureText STRICT.
@torden
Copy link
Contributor

torden commented Jul 11, 2019

Oops, I will make a PR with #1457

torden added a commit to torden/revel that referenced this issue Jul 12, 2019
@torden
Fixed (revel#1458) the undetected self-closing tags in isPureTextStrict
7f8a7d8 
Fixed (revel#1458) the always uses STRICT mode in PureText.IsSatisFied
This was referenced Jul 12, 2019
Closed
Closed
@torden
Copy link
Contributor

torden commented Jul 17, 2019

I would take it after failed to TestMemcachedXXX cases on travis-ci

torden added a commit to torden/revel that referenced this issue Jul 18, 2019
@torden
Fix (revel#1458) the undetected self-closing tags in isPureTextStrict
fe4861c 
Fix (revel#1458) the always uses STRICT mode in PureText.IsSatisFied
@torden torden mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Madisonw @brendensoares @torden