Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio files doesn't work if added in "question" part of card #109

Open
artyom-intellias opened this issue May 23, 2022 · 3 comments · May be fixed by #159
Open

Audio files doesn't work if added in "question" part of card #109

artyom-intellias opened this issue May 23, 2022 · 3 comments · May be fixed by #159
Labels
bug Something isn't working

Comments

@artyom-intellias
Copy link

artyom-intellias commented May 23, 2022 •
edited

image

i'm almost sure that it could be fixed by adding
medias = medias.concat(this.getAudioLinks(question))
@artyom-intellias artyom-intellias added the bug Something isn't working label May 23, 2022
@github-actions
Copy link

Thank you for taking the time to report the issue and help me to make the project better! 🙂

@reuseman
Copy link
Owner

@artyom-intellias if you do a pull request and test it out I would be glad

timgreen added a commit to timgreen/flashcards-obsidian that referenced this issue Nov 1, 2022
@timgreen
Handle the audios in "question" part of card.
ab66e76 
Closes reuseman#109
@timgreen timgreen linked a pull request Nov 1, 2022 that will close this issue
Open
@timgreen
Copy link

timgreen commented Nov 1, 2022

I ran into the same issue. Created the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle the audios in "question" part of card. timgreen/flashcards-obsidian
3 participants
@timgreen @reuseman @artyom-intellias