Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot urls continue to be exported even after deletion. #771

Closed
JohnLukeBentley opened this issue Nov 8, 2017 · 6 comments
Closed

Snapshot urls continue to be exported even after deletion. #771

JohnLukeBentley opened this issue Nov 8, 2017 · 6 comments

Comments

@JohnLukeBentley
Copy link

JohnLukeBentley commented Nov 8, 2017

Snapshot urls continue to be exported even after deletion.

Steps to reproduce:

  1. Open Zotero.

  2. In Firefox surf to http://www.abc.net.au/news/2017-11-09/conservatives-to-sponsor-alternative-same-sex-marriage-bill/9131826 (or Skip ahead to step 5 and use Report ID: 7F6B9KDH)

  3. In Firefox click on the Zotero button (which will export with the "Save to Zotero (Embedded Metadata)" command).

  4. In Zotero observe that the web page has been saved with a snapshot.

  5. In Zotero click on the new record and export (Ctrl + Shift + C ... with Better Biblatex set).

  6. Paste into an editor. Observe ...

    @online{barbour_2017_conservative,
    author = {Barbour, political reporter Lucy},
    ...
    file = {Snapshot:C:\Users\John\Documents\CustomData\Direct\Live\Zotero\storage\YL92HK6A\9131826.html:text/html},
    ...

    That is, as expected a file = {Snapshot url exists.

  7. In Zotero click on the record's triangle near the title to open up the snapshot record underneath.

  8. On the snapshot record right click > Move Item to Trash ... . Click OK. Observe the snapshot has been deleted from Zotero.

  9. Export again (Ctrl + Shift + C ... with Better Biblatex set).

  10. Paste into your editor and observe the exported record is unchanged. Specifically, ...

    file = {Snapshot:C:\Users\John\Documents\CustomData\Direct\Live\Zotero\storage\YL92HK6A\9131826.html:text/html}

    ... remains, when it shouldn't.

In addition, for a record that had its snapshot removed: restarting Zotero doesn't remove the snapshot url on export.

I'm on Zotero 5.0.24. Firefox 57.0 (64bit). zotero-better-bibtex-5.0.31.4637.issue-590.xpi. Note this arouse while testing in the #590 branch.

@retorquere
Copy link
Owner

This is likely a cache invalidation problem, in turn likely caused by zotero not notifying parent references as changed when their children do.

I'm on the go right now, but could you shut down zotero, go into your zotero directory, subdirectory better-bibtex, remove cache.json, and retry the export (so not the removal, do that before)? If that gets you the correct output I'll have confirmation.

@JohnLukeBentley
Copy link
Author

Yes deleting ...\Zotero\better-bibtex\cache.json and retrying the export did indeed produce the correct output (Snapshot url no longer exported).

@blip-bloop
Copy link
Collaborator

🤖 this is your friendly neighborhood build bot announcing test build 4666 ("fixes #771").

@JohnLukeBentley
Copy link
Author

That fixes it! :)

@blip-bloop
Copy link
Collaborator

🤖 this is your friendly neighborhood build bot announcing test build 4667 ("fixes #771").

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants