Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zotero 7 Beta] Missing Dark Mode icon for the Citation Key section in the Item Pane #2861

Open
mjthoraval opened this issue May 1, 2024 · 13 comments

Comments

@mjthoraval
Copy link

Debug log ID

WBBI5KQ2-euc/6.7.181-7

What happened?

The black icon in Dark Mode is not clearly visible:
image

@mjthoraval mjthoraval changed the title Missing Dark Mode icon for the Citation Key section in the Item Pane [Zotero 7 Beta] Missing Dark Mode icon for the Citation Key section in the Item Pane May 1, 2024
@retorquere
Copy link
Owner

I don't have a better icon. If you have one (16*16) I'll gladly take it.

@llity
Copy link

llity commented May 2, 2024

Icons need to be redesigned.

@retorquere
Copy link
Owner

So redesign it and attach it here. I don't have a better icon. This answer isn't going to change. Unless someone can offer a better icon, commenting here is pointless.

@ramonmi
Copy link

ramonmi commented May 6, 2024

There may be a candidate for you to consider. The color is selected from the typical color in the highlight pane of the pdf reader, which could contribute to adaptively display in dark mode. The reason for choosing the key comes from the word in the term ‘citationkey’.
candidate-citation-key

@retorquere
Copy link
Owner

Works for me, a new release will drop soon.

@ramonmi
Copy link

ramonmi commented May 8, 2024

Works for me, a new release will drop soon.

I'm glad this icon has been applied in the latest release. However, the icon in the far right sidebar seems too small and not centered, while the typical icon in the right pane is normal.

  • The vector diagram such as SVG format may donate to a clearer effect than PNG.

dark-mode
light-mode

@retorquere
Copy link
Owner

I'll see if zotero can handle svg there, because they said 16x16, and svgs don't have an intrinsic size. But all of this is temporary. When I get the api to add the citekey to the info section, this section will go away.

@retorquere
Copy link
Owner

Seems to work.

@ramonmi
Copy link

ramonmi commented May 8, 2024 via email

@github-actions github-actions bot reopened this May 8, 2024
@llity
Copy link

llity commented May 8, 2024

Text not aligned
image

@ramonmi
Copy link

ramonmi commented May 8, 2024

The latest release works well. Looking forward to the cite key in the info section.

@retorquere
Copy link
Owner

Text not aligned

I know, but it's functional, so I'm going to leave it for now. The API they're going to add will surely address this.

@retorquere
Copy link
Owner

The latest release works well. Looking forward to the cite key in the info section.

Same here, but there's no telling when that will come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants