-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExecuteTaskAsync marked as obsolete #1401
Comments
I ran into the same problem. |
I am open to suggestions. The naming is bad in the first place. |
Okay that explains it a bit more. |
Ok, I am able to make the I will continue moving to new names as far as signatures don't overlap. Hopefully, the next version will be better in that regard. |
Ok, I completed the work on new methods now. |
Thanks for sorting |
Expected Behavior
Methods only marked as obsolete if there is an alternative available to use.
Actual Behavior
All the async methods on IRestClient have been marked as obsolete ( e.g. ExecuteTaskAsync which returns Task<IRestResponse> .
This means a whole load of compile time warnings/errors (all of our projects have warnings as errors enabled).
The only way round this is to either suppress this specific compile time warning (undesirable as will not then pick up on other uses of obsolete methods), or to go through and individually suppress the warning for each usage of these methods (hundreds of lines of code changes).
I would understand the use of Obsolete here if there was another alternative method call we should be using instead- but there isn't ! I'm not sure of the value that the Obsolete attribute is providing on these ExecuteTaskAsync methods- these are not obsolete as far as I can see as there is no alternative to use? Nor is it really useful to be told these are going to be renamed - as there's nothing I can do about it anyway.
Steps to Reproduce the Problem
Specifications
The text was updated successfully, but these errors were encountered: