fix: don't create empty clientError listener for http.Server #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelis
changed the title
josephharrington
approved these changes
Mar 23, 2022
josephharrington
changed the title
josephharrington
added a commit
that referenced
this pull request
Mar 23, 2022
In the recent fix #1895, the `clientError` event was removed from the list of events proxied from the underlying server object to the restify Server. That fix was needed because merely adding a listener to the underlying server for the `clientError` event prevents the default behavior of returning an appropriate error code and closing the socket. So by setting up a listener to proxy the event we were preventing that default behavior, leading to hanging/leaked requests. But! We should still support proxying `clientError` events if restify users have added a listener for it. This enables logging or other custom behavior. Restify users adding a `clientError` listener take on the responsibility of sending an appropriate error and closing the socket, exactly as noted in the Node.js docs for the `clientError` event. https://nodejs.org/docs/latest-v16.x/api/http.html#event-clienterror This change ensures we add a listener for `clientError` to the underlying server object if and only if a listener for `clientError` has been added to the restify server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
Changes
clientErrorlistener forhttp.Server.