Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bunyan with pino #1838

Closed
ghermeto opened this issue Jul 1, 2020 · 3 comments
Closed

Replace bunyan with pino #1838

ghermeto opened this issue Jul 1, 2020 · 3 comments
Assignees

Comments

@ghermeto
Copy link
Member

ghermeto commented Jul 1, 2020

Prefer Pino

Why?

Well maintained, performance-focused, compatible API. Today we always pass a Pino instance to createServer().

Breaking change

bunyan_helper has a complex implementation of RequestCaptureStream based on Bunyan multi-stream and RingBuffer capabilities that Pino don't have. I propose we dropRequestCaptureStream entirely, as it is only used if the user doesn't provide any logger themselves.

Are you willing and able to implement this?

Yes

@DonutEspresso
Copy link
Member

I don't feel strongly. If folks depend on the RCS implementation we could re-publish it as its own module. Seems pretty low effort and we could ship it with the next breaking change.

@ghermeto
Copy link
Member Author

ghermeto commented Jul 2, 2020

👍

@ghermeto
Copy link
Member Author

ghermeto commented Jul 4, 2020

Done on #1841... I can publish RequestCaptureStream as its own module if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants