You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Well maintained, performance-focused, compatible API. Today we always pass a Pino instance to createServer().
Breaking change
bunyan_helper has a complex implementation of RequestCaptureStream based on Bunyan multi-stream and RingBuffer capabilities that Pino don't have. I propose we dropRequestCaptureStream entirely, as it is only used if the user doesn't provide any logger themselves.
Are you willing and able to implement this?
Yes
The text was updated successfully, but these errors were encountered:
I don't feel strongly. If folks depend on the RCS implementation we could re-publish it as its own module. Seems pretty low effort and we could ship it with the next breaking change.
Prefer Pino
Why?
Well maintained, performance-focused, compatible API. Today we always pass a Pino instance to
createServer()
.Breaking change
bunyan_helper has a complex implementation of
RequestCaptureStream
based on Bunyan multi-stream and RingBuffer capabilities that Pino don't have. I propose we dropRequestCaptureStream
entirely, as it is only used if the user doesn't provide any logger themselves.Are you willing and able to implement this?
Yes
The text was updated successfully, but these errors were encountered: