feat(deps): replace cover/istanbul with nyc #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`istanbul` is not supported anymore, and the last version of `cover` was released seven years ago. `cover` also depends on a vulnerable package (which makes `npm audit` noisy). Since `make cover` was not working anymore, replacing it with `nyc` (`istanbul`'s successor) should be straightforward. Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
|
I only ended up here because of the release please PR, so sorry if this is bringing up something unnecessarily, but have you considered using |
|
Haven't looked into it yet. What made you change? How hard was the change? I think nyc is working for us right now, but I'm open to changing if it becomes a problem at some point. |
|
It was super simple to change, just swap in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istanbulis not supported anymore, and the last version ofcoverwasreleased seven years ago.
coveralso depends on a vulnerable package(which makes
npm auditnoisy). Sincemake coverwas not workinganymore, replacing it with
nyc(istanbul's successor) should bestraightforward.
Signed-off-by: Matheus Marchini mmarchini@netflix.com
Pre-Submission Checklist
make prepush