Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): address domain performance regression with Node v12.x #1809

Merged
merged 2 commits into from Dec 13, 2019

Conversation

hekike
Copy link
Member

@hekike hekike commented Dec 2, 2019

$ node -v
v12.13.1
$ make benchmark 
? Do you want to track progress? No
? Do you want to compare HEAD with the stable release (7.2.0)? Yes
? Do you want to run all benchmark tests? Yes
? How many connections do you need? 100
? How many pipelining do you need? 10
? How long does it take? 30
---- response-json ----
✔ Results saved for head/response-json
✔ Results saved for stable/response-json
response-json throughput:
{
    "significant": "***",
    "equal": false,
    "wins": "head",
    "diff": "235.59%"
}

---- response-text ----
✔ Results saved for head/response-text
✔ Results saved for stable/response-text
response-text throughput:
{
    "significant": "***",
    "equal": false,
    "wins": "head",
    "diff": "204.37%"
}

---- router-heavy ----
✔ Results saved for head/router-heavy
✔ Results saved for stable/router-heavy
router-heavy throughput:
{
    "significant": "***",
    "equal": false,
    "wins": "head",
    "diff": "197.09%"
}

---- middleware ----
✔ Results saved for head/middleware
✔ Results saved for stable/middleware
middleware throughput:
{
    "significant": "***",
    "equal": false,
    "wins": "head",
    "diff": "157.24%"
}

cc thanks @mmarchini and @daviande for the finding!

Copy link
Contributor

@daviande daviande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmarchini
Copy link
Contributor

We also need to upgrade restify-errors once restify/errors#101 is merged and released.

@hekike hekike force-pushed the fix/domain-performance-regression branch from 8c45bcf to ce5911a Compare December 13, 2019 21:38
@hekike
Copy link
Member Author

hekike commented Dec 13, 2019

@mmarchini restify-errors updated.

@hekike hekike merged commit e648d49 into master Dec 13, 2019
@hekike hekike deleted the fix/domain-performance-regression branch December 13, 2019 21:43
@hekike
Copy link
Member Author

hekike commented Dec 13, 2019

released as restify@8.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants