fix(plugins): do not include user-input in UnsupportedMediaTypeError #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LTS fails but @misterdjules is working on a fix, unrelated to this pr. |
|
Nitpicking and thinking out loud: should that be a minor version bump since we're adding an info field to the error object (which one could argue is technically an addition to the plug-in's API)? |
misterdjules
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
Nitpicking again: the commit message seems to be slightly misleading: IIUC this change still includes user-input in the error, but instead of including it in the error message it includes it in a separate field. We might want to change the commit message to reflect that.
hekike
force-pushed
the
fix/plugin-body-reader-error-message
branch
from
33b60e1
to
e97e364
Compare
… message (VError fails), move it to info
hekike
force-pushed
the
fix/plugin-body-reader-error-message
branch
from
e97e364
to
691f455
Compare
|
Minor sounds good to me, I think the reasoning is valid. |
DonutEspresso
approved these changes
Jan 2, 2019
|
released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User input in
VErrorbased errors (restify-errors) can cause the process to crash asVErroruses thesprintflibrary internally which expects additional arguments for formatting symbols liek%s.For example, a
content-type%swould crash restify without this change.