[Restify 7] Fix uncaught exceptions triggering route lookups #1717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepush
Issues
The current
uncaughtException
handler attempts to do route lookup if a string is thrown. This behavior is undesirable because it prevents the application from handling the exceptions itself (it never makes it to the user'suncaughtException
handler.Changes
This PR adds a check to the route lookup logic which is typically used when calling
next('myString')
. It bypasses this code if it handling an uncaught exception.The test demonstrates how this could be triggered before these code changes:
throw 'bar'
. I also had to add a check forerr.name
since that would throw another error in the case of a string being passed to theerrEvtNameFromError
function. I made the default an empty string, but could use some feedback on whether that makes sense or not.