Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v10 support #1665

Closed
DonutEspresso opened this issue May 27, 2018 · 1 comment
Closed

Node v10 support #1665

DonutEspresso opened this issue May 27, 2018 · 1 comment

Comments

@DonutEspresso
Copy link
Member

It looks like something changed between v10.1.0 and v10.2.0 that caused tests to start failing. Given v10 isn't LTS this isn't super high priority yet.

The 10.2.0 changelog is here:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#10.2.0

Unclear at the moment if this is due to a way we are using undocumented APIs, or something in core changing.
@hekike
Copy link
Member

hekike commented Jun 10, 2018

Fixed by: #1672

@hekike hekike closed this as completed Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hekike @DonutEspresso