Use Buffer.isBuffer instead of util.isBuffer.
#1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thank you for this! Looks like the tests are failing lint, |
retrohacker
requested changes
Jan 30, 2018
There was a problem hiding this comment.
Assuming removing util gets the tests to pass, I'm 👍 for merging this!
Thank you @NatalieWolfe! ❤️
|
@retrohacker Yup, forgot to commit that correction after running the tests! Original change was done via GitHub's web UI which doesn't run commit hooks. |
NatalieWolfe
added a commit
to newrelic/node-newrelic
that referenced
this pull request
Feb 1, 2018
|
@retrohacker The tests are passing now. |
retrohacker
approved these changes
Feb 9, 2018
This was referenced Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
No issues opened for this.
Changes
Replaced
util.isBuffercall withBuffer.isBuffer.util.isBufferwas introduced in Node 0.11 and deprecated in Node 4.Buffer.isBufferwas introduced in Node 0.1 and has not been deprecated. Since Restify supports back to 0.10 according to the package.jsonenginesfield,util.isBuffercannot be used.