Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request): date() and time() methods return value #1576

Merged
merged 1 commit into from Dec 11, 2017

Conversation

hekike
Copy link
Member

@hekike hekike commented Nov 29, 2017

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Fix fix req.time() and req.date() return value.

Changes

  • fix req.time() and req.date()
  • cover with tests

Copy link
Member

@retrohacker retrohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@retrohacker retrohacker merged commit 4c2cb1a into master Dec 11, 2017
@hekike hekike deleted the fix/request-date-time branch December 12, 2017 07:43
@hekike
Copy link
Member Author

hekike commented Dec 12, 2017

@retrohacker thanks, it's broken by some unexpected style changes.
Seems to be that prettier fails to follow SemVer :/

Fix: #1583

@hekike hekike mentioned this pull request Dec 12, 2017
@BryanDonovan
Copy link
Contributor

When will this change be available in a release?

@simonepri
Copy link
Contributor

@BryanDonovan
A simple workaround in the meanwhile:

server.on('pre', req => {
    req._date = new Date();
});

@DonutEspresso
Copy link
Member

To close the loop on this, fix should have landed in latest 6.x and 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants