server _routeErrorResponse avoiding uncaughtException by only sending response when not sent #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hekike test proven |
hekike
reviewed
Nov 20, 2017
test/server.test.js
Outdated
| ) { | ||
| SERVER.on('MethodNotAllowed', function(req, res, error, next) { | ||
| res.json(405, { status: 'MethodNotAllowed' }); | ||
| var nextHasErrored; |
There was a problem hiding this comment.
You can do this:
try {
next();
} catch (err) {
t.fail('next() should not throw error when header has already been sent');
}
t.end();
|
@beckend thanks, a small comment, otherwise looks great! |
beckend
changed the title
hekike
approved these changes
Nov 21, 2017
|
@beckend thanks for your contribution! Landed as |
hekike
added a commit
that referenced
this pull request
Nov 21, 2017
…nly sending response when not sent test from #1568
hekike
added a commit
that referenced
this pull request
Nov 24, 2017
…nly sending response when not sent test from #1568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
middlewares and routes which send response normally, however server listeners such as MethodNotAllowed will trigger the route error handler and send response regardless if payload has been sent or not and causes an uncaughtException needlessly.
Closes: