Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: dropping Node.js support < v4.0.0 #1553

Merged
merged 1 commit into from Feb 1, 2018

Conversation

hekike
Copy link
Member

@hekike hekike commented Nov 3, 2017

Drop Node.js support below v4.0.0.
Revisit TravisCI Node.js versions, only keep the supported releases:

  • Maintenance LTS (4.x)
  • Current LTS
  • Latest release

Changes

  • package.json engines
  • TravisCI config

@hekike
Copy link
Member Author

hekike commented Nov 3, 2017

Jobs are broken on 0.10 because the lack of ES6 support which is required by our dependencies.

We haven't been running tests on < 4.0.0 since December 2016 (see: 2f0f177#diff-354f30a63fb0907d4ad57269548329e3).

Shouldn't we drop < 4.0.0 support from restify if we don't test it continuously?

cc @yunong @retrohacker @DonutEspresso

@DonutEspresso
Copy link
Member

Agreed - moving forward we should feel comfortable following Node's LTS schedule - if it's outside LTS I don't think we have the bandwidth to support it.

@hekike hekike force-pushed the chore/travisci-node-versions branch from ecc9230 to 5c9cdb6 Compare November 15, 2017 08:08
@hekike hekike changed the base branch from master to next November 15, 2017 08:08
@hekike hekike changed the base branch from next to master November 15, 2017 08:09
@hekike hekike changed the title chore(travisci): revisit nodejs versions chore(travisci): dropping Node.js support < v4.0.0 Nov 15, 2017
@hekike
Copy link
Member Author

hekike commented Nov 15, 2017

@DonutEspresso I changed the PR to drop support < v4.0.0 as 4.x this is the current LTS Maintenance release.
@retrohacker should it go to the next branch? It's a breaking change.

@retrohacker retrohacker changed the base branch from master to next November 17, 2017 06:54
@retrohacker retrohacker changed the title chore(travisci): dropping Node.js support < v4.0.0 BREAKING CHANGE: dropping Node.js support < v4.0.0 Nov 17, 2017
@retrohacker
Copy link
Member

Woah, looks like next needs to be rebased 😂

…aintenance (4.x) and stable releases

BREAKING CHANGE: dropping support below Node.js 4
@hekike hekike force-pushed the chore/travisci-node-versions branch from 954e5c1 to 5e19550 Compare January 30, 2018 23:13
@hekike hekike merged commit 51bd490 into next Feb 1, 2018
@hekike hekike deleted the chore/travisci-node-versions branch February 1, 2018 19:19
hekike added a commit that referenced this pull request Feb 23, 2018
…aintenance (4.x) and stable releases (#1553)

BREAKING CHANGE: dropping support below Node.js 4
hekike added a commit that referenced this pull request Mar 13, 2018
…aintenance (4.x) and stable releases (#1553)

BREAKING CHANGE: dropping support below Node.js 4
hekike added a commit that referenced this pull request Mar 20, 2018
…aintenance (4.x) and stable releases (#1553)

BREAKING CHANGE: dropping support below Node.js 4
hekike added a commit to sfaizanh/node-restify that referenced this pull request Mar 27, 2018
…aintenance (4.x) and stable releases (restify#1553)

BREAKING CHANGE: dropping support below Node.js 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants