Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): use process.hrtime() for duration calculation #1507

Merged
merged 2 commits into from Oct 9, 2017

Conversation

hekike
Copy link
Member

@hekike hekike commented Sep 30, 2017

Pre-Submission Checklist

  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Date.now() is a subject to clock drift, for performance measuring process.hrtime() is a better choice

Changes

  • uses process.hrtime() for request duration meassurement
  • removes unused res._time

Copy link
Member

@retrohacker retrohacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm 👍

Thanks for this! Sorry for the delay in responding.

@retrohacker retrohacker merged commit e8efd6c into restify:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants