fix: dont include interval in lag #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* plugin.close for all tests
|
Hmm, make prepush works for me locally. Removing arrow function. |
DonutEspresso
previously requested changes
Sep 27, 2017
| @@ -30,7 +30,7 @@ describe('cpuUsageThrottle', function () { | |||
| var opts = { limit: 0, interval: 500 }; | |||
| var plugin = cpuUsageThrottle(opts); | |||
| function next (cont) { | |||
| clearTimeout(plugin._timeout); | |||
| plugin.close(); | |||
There was a problem hiding this comment.
Should this just be in an afterEach block?
There was a problem hiding this comment.
Is there a way to do that without maintaining state outside the test?
There was a problem hiding this comment.
Not that I know of - usually just use a plugin var within the closure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushChanges
Currently the
lagmetric forcpuUsageThrottleincludes the interval. For example, an interval of50firing at the exact right moment will result in a lag of50as opposed to0. This fixes that.Also, this PR removes all timeouts after the
cpuUsageThrottletests.