Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude package-lock.json #1477

Merged
merged 1 commit into from Sep 8, 2017
Merged

fix: exclude package-lock.json #1477

merged 1 commit into from Sep 8, 2017

Conversation

retrohacker
Copy link
Member

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

  • Issue #
  • Issue #
  • Issue #

Summarize the issues that discussed these changes

Changes

What does this PR do?

@retrohacker retrohacker merged commit 011fdf0 into master Sep 8, 2017
@sean3z sean3z deleted the packagelock branch September 12, 2017 13:09
@hekike
Copy link
Member

hekike commented Sep 29, 2017

@retrohacker what's the reason behind ignoring package-lock.json?

@hekike hekike mentioned this pull request Sep 29, 2017
Closed
3 tasks
@hekike hekike mentioned this pull request Oct 9, 2017
Merged
@retrohacker retrohacker mentioned this pull request Oct 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@retrohacker @hekike