fix(static): avoid user-provided data in Error messages being interpreted as sprintf codes #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eted as sprintf codes (#1384) The 'static' plugin had a few cases where the path in a request would be passed as the first ("message") field to a RestError constructor. RestError uses verror.WError, which uses extsprintf to render the given arguments. If the "message" includes "%...s" or similar printf codes, then it will error output. Also bump to 4.3.1. * drop ver bump changes, per review comments * update test name and drop comment (unnecessary with issue ref) per review comments
|
Merging as review was done on #1384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1384 but for 5.x. Fixes #1411
I cherry picked @trentm's commits, and migrated tests to the new directory.