Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inflight request throttle fix #1471

Merged
merged 2 commits into from Sep 7, 2017
Merged

Conversation

retrohacker
Copy link
Member

  • Always call next
  • Abort middleware chain by passing false when shedding load
  • Fix error messages
  • Remove accidental onRequest on prototype

* Always call next
* Abort middleware chain by passing `false` when shedding load
* Fix error messages
* Remove accidental onRequest on prototype
Copy link
Member

@DonutEspresso DonutEspresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@retrohacker
Copy link
Member Author

Failing tests are nsp shrinkwrap issues which should be resolved upstream. Merging.

@retrohacker retrohacker merged commit 4db404f into master Sep 7, 2017
@sean3z sean3z deleted the inflightRequestThrottleFix branch September 12, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants