Fix: 652 - Incorrect error on route with no versions #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking this up, @karthikiyengar! Always great to see new contributors. 🎉 What's your comfort level on adding tests that cover this new behavior? It would be great to see a test for both a mismatching version as well as a missing version, as reported originally in #652. |
|
@DonutEspresso - Sure, I can add some tests. Thank you for the library, I've had much fun using it :-) |
|
Tests added 😄 |
|
🎉 This is awesome @karthikiyengar !!!!!! Thanks for doing this, the PR looks good to me! |
|
Fantastic. Thanks @karthikiyengar! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes: #652
Changes
Throws in InvalidVersionError instead of a MethodNotAllowedError when a route with no versions is called with the 'Accept-Version' header