Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 7-8 travis support #1405

Merged
merged 1 commit into from Jul 11, 2017
Merged

Add node 7-8 travis support #1405

merged 1 commit into from Jul 11, 2017

Conversation

simonepri
Copy link
Contributor

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Changes

Restify is fully compatible with both node 7 and 8 and they are quite used in production also if they aren't LTS at the moment.

@simonepri
Copy link
Contributor Author

Some steps fails on Travis, but since you already support the stable version (That at the moment installs node 8) I think they are problem unrelated to this PR.

@retrohacker retrohacker merged commit 536a473 into restify:5.x Jul 11, 2017
@retrohacker
Copy link
Member

Thanks @simonepri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants