GH-1380 versioned route matching should not throw TypeError #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrohacker
approved these changes
Jun 26, 2017
There was a problem hiding this comment.
This LGTM 👍 we need to provide a default value for maxV, and the first encountered semver range seems to be the best default. Alternatively I could see us using 0.0.0 but I don't know if that is strictly the "lowest" semver value possible.
Thank you @kusor for providing tests 😄
|
Merging at EOD 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes:
Changes
Avoid exceptions being thrown when we have two routes applicable to the same request, one typed and the other versioned and not typed.