Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.1 to 16.4 regression (win) - filters with character range for drive letters no longer work compared to 16.0 and earlier #4723

Open
msoltyspl opened this issue Mar 3, 2024 · 0 comments

Comments

@msoltyspl
Copy link

Output of restic version

restic 0.16.4 compiled with go1.21.6 on windows/amd64

Note: all versions tested below are from the github's release page.

What backend/service did you use to store the repository?

Tested against local storage and backblaze (b2)

Problem description / Steps to reproduce

Exclusion patterns using character range to limit disk drives no longer work starting with version 16.1, for example:

[cCrR]:/Program File*
[cCrR]:/Windows

If such exclude patterns - stored in file test.txt - are used in the following invocation:

restic_0.16.4_windows_amd64.exe -r s:\windrivebackup --iexclude-file=./test.txt --use-fs-snapshot c:/

Then both Windows, Program Files and Program Files (x86) will be included in the backup.

0.16.0 and earlier versions work fine.

Note that using ? instead of the character range still works correctly.
Case sensitivity or insensitivity doesn't seem to matter either (--iexclude and --exclude produce same results in the above example).

Expected behavior

Allow to use character ranges to limit drives as in 0.16.0 and earlier versions

Do you have any idea what may have caused this?

No changes, besides upgrading from 0.15.2 and making fresh snapshots of my data.

Did restic help you today? Did it make you happy in any way?

Small bug aside, restic rocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant