Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --verify flag to dump command #4699

Open
27149chen opened this issue Feb 12, 2024 · 3 comments
Open

add --verify flag to dump command #4699

27149chen opened this issue Feb 12, 2024 · 3 comments

Comments

@27149chen
Copy link
Contributor

Output of restic version

restic 0.16.2 (v0.16.2-63-gb72de5a88) compiled with go1.21.0 on linux/amd64

What should restic do differently? Which functionality do you think we should add?

add --verify flag to dump command just like restore

What are you trying to do? What problem would this solve?

I want to restore a block device and verify it after restore

Did restic help you today? Did it make you happy in any way?

we built a wonderful solution on top of Resic, it really help

@MichaelEischer
Copy link
Member

Such an option could only work when using the --target option for the dump command. It is impossible to add when the output is written to stdout.

I don't think such an option is particularly useful. dump already verifies each blob before writing it to the target file.

@27149chen
Copy link
Contributor Author

@MichaelEischer --verify can also be used to verify the content in the tarball. If you dump the whole snapshot as a tarball, it is similiar with the --verify in restore command

@MichaelEischer
Copy link
Member

I'm still not really sure how useful a --verify option would be for the dump command. But I'd be ok if someone implements such an option, as long as it doesn't lead to too much code duplication (maybe some parts of the verify functionality in the restore command can be reused).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants