Add SSO support for AWS S3 Backend #4721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,7 @@ | |||
| module github.com/restic/restic | |||
|
|
|||
| replace github.com/minio/minio-go/v7 => ../minio-go | |||
There was a problem hiding this comment.
That references a local folder on your disk. Why not directly reference the commits from the mentioned minio-go PR?
There was a problem hiding this comment.
Hey, I was not aware of that method initially. 😅
I will update this to the specific commit hash.
I have marked the MR in draft for the same.
|
@konidev20 I'll close that PR for now, feel free to open a new one once there's something to review. |
|
@MichaelEischer sure, I don't think anyone is working on that PR from the MinIO team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
./aws/sso-cacheto authenticate to AWS S3.Was the change previously discussed in an issue or on the forum?
Closes #4688
issue from minio/minio-go: minio/minio-go#1930
pr from minio/minio-go: minio/minio-go#1911
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.