-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGHUP #80
Labels
Comments
Have you tried with |
Right. I have another workaround for the moment. Can we repurpose this issue then to have |
Sure, I think we can do that. So what behavior do you need for the log rotation to work? Just ignore HUP? |
No, for log rotation to work, we'd need to have rest-server reopen every fds it has open, so that logrotate can move/archive them. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is related to https://forum.restic.net/t/rest-server-crashes-or-exits-unexpectedly/1073/4
version: 0.9.7 or dfe9755 (master)
Steps to reproduce
kill -HUP <pid>
What happens
rest-server exits.
What I expect
At least not to die, (ignoring the signal?). Reloading log files would be nice, and that seems to be the usual behaviour for this signal.
Some background, I discovered this because rest-server was unexpectedly dying, and logfiles would be empty. It appears that synology, the box we're running it on, generated a logrotate configuration for it and was killing it every so often. That wasn't fun.
I deactivated it for now, but handling SIGHUP would be nice. Rotating log files can be useful :)
The text was updated successfully, but these errors were encountered: