Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries do not get uninstalled #445

Open
jgalan opened this issue Jun 15, 2023 · 3 comments
Open

Libraries do not get uninstalled #445

jgalan opened this issue Jun 15, 2023 · 3 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@jgalan
Copy link
Member

jgalan commented Jun 15, 2023

I have disabled a library from the compilation,

E.g. cmake -DRESTLIB_AXION=OFF ..

However, when I execute restRoot in the new installed version of REST the library is still loading.

I believe the uninstall system is not working with .so installed libraries?

@jgalan jgalan added the invalid This doesn't seem right label Jun 15, 2023
@juanangp
Copy link
Member

I cannot reproduce the issue, while doing make uninstall all the libraries are properly uninstalled.

Perhaps this is a corner case when you do cmake -DRESTLIB_AXION=OFF ... in the same build? In this case would be better to call make uninstall before doing cmake.

@jgalan
Copy link
Member Author

jgalan commented Jul 19, 2023

Yes, may be, it couldn't be that the cmake detects that I used -DRESTLIB_AXION=OFF and calls make uninstall? Or that whenever we invoke cmake the make uninstall is invoked?

@juanangp
Copy link
Member

Yes, may be, it couldn't be that the cmake detects that I used -DRESTLIB_AXION=OFF and calls make uninstall? Or that whenever we invoke cmake the make uninstall is invoked?

We invoke make uninstall whenever make install is invoked, we cannot do at cmake because the install_manifest might not be generated at this stage.

In fact, I think the problem is in the cmake itself since I think that axionlib still gets installed after doing cmake -DRESTLIB_AXION=ON ... and then cmake -DRESTLIB_AXION=OFF ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants