Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions framework cache not working as expected #411

Open
lobis opened this issue May 8, 2023 · 0 comments · May be fixed by #365
Open

GitHub Actions framework cache not working as expected #411

lobis opened this issue May 8, 2023 · 0 comments · May be fixed by #365
Assignees
Labels
bug Something isn't working

Comments

@lobis
Copy link
Member

lobis commented May 8, 2023

When debugging the following PR: #365 I found an error in the GitHub Actions workflow.

It seems that the caching of the framework is instead restoring the cache (because a key already exists) but this should be unique each workflow run, so this should not happen. One can see this in the following run:

https://github.com/rest-for-physics/framework/actions/runs/4913830534/jobs/8774448343

In particular the workflow is failing because the installation directory for Garfield differs between Docker images, the installation with the correct image is not being saved into the cache because the key is already populated.

I guess we should use a more robust cache key identifier so this cannot happen.

@lobis lobis added the bug Something isn't working label May 8, 2023
@lobis lobis linked a pull request May 8, 2023 that will close this issue
@lobis lobis self-assigned this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant