Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical issue. Urgent help needed. TRestProcessRunner conflicts with metadata class #296

Open
jgalan opened this issue Sep 12, 2022 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jgalan
Copy link
Member

jgalan commented Sep 12, 2022

Hi,

when we are launching @jovoy the processing chain given in the attached configuration file:

restManager --c opticsBench.rml

it will run without issues when we define a TRestAxionGeneratorProcess with a flat generator type. However, if we define a solarFlux generator type, it will happen that only a few events are launched by TRestProcessRunner.

Just guessing we found that the TRestAxionSolarFlux seed value was affecting to the result, when solarFlux is the generator type. So, changing the seed sometimes the processing chain breaks, sometimes it generates a different number of primaries.

opticsBench.txt

Hope @nkx111 you got an idea about what is wrong here

@jgalan jgalan added bug Something isn't working help wanted Extra attention is needed labels Sep 12, 2022
@jgalan
Copy link
Member Author

jgalan commented Sep 12, 2022

BTW, solarSeed on the attached file should be simply seed. I was doing a test changing the parameter name, but it did not affect.

@jgalan
Copy link
Member Author

jgalan commented Sep 13, 2022

Ok, I understand now what it is happening. We have a condition, if the energy is above a given value, then the process will return nullptr. I thought this would skip the event, but instead is terminating the event processing.

That why if we change the seed the number of events changes, once the event energy is above 10, it will end the event.

This was done like that before, so, @nkx111 what we should do now to simply skip the event?

@jgalan
Copy link
Member Author

jgalan commented Sep 13, 2022

However, in other processes this is done like that if (ApplyCut()) return nullptr;

@jgalan
Copy link
Member Author

jgalan commented Sep 13, 2022

I found a way to bypass the problem, but the issue it is still there. Why when we return nullptr the event processing stops instead of just skipping the event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants