Drop support for old Garfield versions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanangp
reviewed
Mar 24, 2022
juanangp
reviewed
Mar 24, 2022
juanangp
reviewed
Mar 24, 2022
jgalan
reviewed
Sep 9, 2022
| @@ -47,7 +41,7 @@ class TRestDetectorGarfieldDriftProcess : public TRestEventProcess { | |||
| TRestDetectorHitsEvent* fInputHitsEvent; //! | |||
| TRestDetectorHitsEvent* fOutputHitsEvent; //! | |||
|
|
|||
| #if defined USE_Garfield | |||
| #if defined REST_GARFIELD | |||
There was a problem hiding this comment.
Could we keep USE_Garfield? It is done like that for other libraries.
We use REST_LIBRARY inside cmake, USE_LIBRARY inside the c++ codes. E.g. USE_SQL, USE_MPFR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #40.
Nothing should change for the user if you use a recent version of Garfield.
After this PR, we should remove the file
FindGarfieldOld.cmakefrom thecmakedir in the framework, as its no longer needed, but it won't cause any issues either.