Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startTime property in RateLimiter #752

Open
walec51 opened this issue Nov 18, 2019 · 3 comments · May be fixed by #2100
Open

startTime property in RateLimiter #752

walec51 opened this issue Nov 18, 2019 · 3 comments · May be fixed by #2100
Assignees
@storozhukBM
Labels
enhancement

Comments

@walec51
Copy link
Contributor

walec51 commented Nov 18, 2019

I propose to add a startTime property to RateLimiterConfig so that we can set from when does a RateLimiting period start. This is necessary if someone wants to user RateLimiter both on his server and client. If you have your clocks in synce then with this property one could make limit period overlap on the server and client.
@RobWin
Copy link
Member

RobWin commented Nov 19, 2019

Hi,

yes, good idea.

@walec51 walec51 mentioned this issue Nov 19, 2019
Closed
@RobWin
Copy link
Member

RobWin commented Jan 29, 2020

FYI @storozhukBM

@storozhukBM storozhukBM self-assigned this Jan 29, 2020
@storozhukBM storozhukBM added this to the 1.3.0 milestone Jan 29, 2020
@RobWin RobWin removed this from the 1.3.0 milestone Apr 22, 2020
@RobWin RobWin mentioned this issue Apr 26, 2022
Open
injae-kim added a commit to injae-kim/resilience4j that referenced this issue Jan 23, 2024
@injae-kim
Add startedTime configuration on RateLimiter
eda8288 
Fixes resilience4jgh-752, resilience4jgh-1668
@injae-kim injae-kim linked a pull request Jan 23, 2024 that will close this issue
Open
injae-kim added a commit to injae-kim/resilience4j that referenced this issue Jan 23, 2024
@injae-kim
Add startedTime configuration on RateLimiter
b441ce2 
Fixes resilience4jgh-752, resilience4jgh-1668
@injae-kim
Copy link

Hi! I created PR #2100 to fix this issue. PTAL when you have some times~ thanks! 😃

injae-kim added a commit to injae-kim/resilience4j that referenced this issue Jan 24, 2024
@injae-kim
Add startedTime configuration on RateLimiter
09d9d1f 
Fixes resilience4jgh-752, resilience4jgh-1668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@storozhukBM storozhukBM

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add startedTime configuration on RateLimiter injae-kim/resilience4j
4 participants
@walec51 @storozhukBM @RobWin @injae-kim