React 19.1 captureOwnerStack #146
Open
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnobip
reviewed
Oct 31, 2025
src/React.res
Outdated
| external act: (unit => promise<unit>) => promise<unit> = "act" | ||
|
|
||
| @module("react") | ||
| external captureOwnerStack: unit => Js.nullable<string> = "captureOwnerStack" |
There was a problem hiding this comment.
If I understood the API, it should return or string, so either use a @return or Null.t.
There was a problem hiding this comment.
I didn't know this decorator, thanks!
Freddy03h
force-pushed
the
captureOwnerStack
branch
from
cddbda2 to
9d612c9
Compare
nojaf
reviewed
Oct 31, 2025
| external act: (unit => promise<unit>) => promise<unit> = "act" | ||
|
|
||
| @module("react") @return(nullable) | ||
| external captureOwnerStack: unit => option<string> = "captureOwnerStack" |
There was a problem hiding this comment.
Nitpick: add a doc comment with link to https://react.dev/reference/react/captureOwnerStack
cknitt
reviewed
Nov 1, 2025
| @module("react") | ||
| external act: (unit => promise<unit>) => promise<unit> = "act" | ||
|
|
||
| @module("react") @return(nullable) |
There was a problem hiding this comment.
Actually @return(null_to_opt) would make the intention clearer as the API can only return string or null according to the docs (but not undefined).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
capureOwnerStackis the only new API in React 19.1 : https://github.com/facebook/react/releases/tag/v19.1.0📖 captureOwnerStack Documentation
Maybe it's possible to have a release for 19.1 before working on React 19.2 new APIs