Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report information about version mismatch when blueprint schema fails to validate #6282

Open
jleibs opened this issue May 9, 2024 · 0 comments
Open

Report information about version mismatch when blueprint schema fails to validate #6282

jleibs opened this issue May 9, 2024 · 0 comments
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working enhancement New feature or request

Comments

@jleibs
Copy link
Member

jleibs commented May 9, 2024

When loading blueprints, we check that all the messages in the blueprint having maching schemas with the currently running executable. However, if this fails, all we get is a cryptic: "Blueprint failed validation" and some very dense debug information showing actual arrow schemas.

Would be nice to show the rerun-version of the data / viewer when this validation fails.
@jleibs jleibs added 🪳 bug Something isn't working enhancement New feature or request 🟦 blueprint The data that defines our UI labels May 9, 2024
@jleibs jleibs changed the title Report information about version mismatch when schema fails to validate Report information about version mismatch when blueprint schema fails to validate May 9, 2024
@jleibs jleibs mentioned this issue May 9, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue May 10, 2024
@jleibs
Validate the blueprint schema when we try to activate a blueprint sen…
3a42904 
…t from SDK (#6283)

### What
- Partially addresses: #6213

We already used to validate on load from file, but this pulls the
validation into the default/activation pathways.
This keeps us from getting into a state where we can't write to the
blueprint due to components with inconsistent schemas.

- Future work: #6282

Unfortunately we can still get issues when opening 0.16 blueprints in
0.15 viewers since 0.15 is missing this validation.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6283?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6283?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6283)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jleibs